Skip to content

[SYCL] Add rcp for fp32 and fp64 with rounding mode supported#11768

Merged
steffenlarsen merged 2 commits into
intel:syclfrom
jinge90:fp_rcp_rounding
Nov 6, 2023
Merged

[SYCL] Add rcp for fp32 and fp64 with rounding mode supported#11768
steffenlarsen merged 2 commits into
intel:syclfrom
jinge90:fp_rcp_rounding

Conversation

@jinge90
Copy link
Copy Markdown
Contributor

@jinge90 jinge90 commented Nov 3, 2023

This PR adds frcp_rd/n/u/z and drcp_rd/n/u/z to sycl::ext::intel::math which corresponds to CUDA math's __frcp_r* and __drcp_r*

@jinge90 jinge90 requested a review from a team as a code owner November 3, 2023 05:50
@jinge90 jinge90 requested a review from bso-intel November 3, 2023 05:50
@jinge90
Copy link
Copy Markdown
Contributor Author

jinge90 commented Nov 3, 2023

Hi, @zettai-reido @akolesov-intel @xtian-github
Could you help review this PR?
Thanks very much.

Copy link
Copy Markdown

@akolesov-nv akolesov-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to map rcp to existing div implementations with rounding

Copy link
Copy Markdown

@xtian-github xtian-github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jinge90 jinge90 requested a review from a team November 6, 2023 08:02
@jinge90
Copy link
Copy Markdown
Contributor Author

jinge90 commented Nov 6, 2023

Hi, @intel/llvm-gatekeepers
Could you help merge this patch?
Thanks very much.

@steffenlarsen steffenlarsen merged commit 9a4719b into intel:sycl Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants