Skip to content

[SYCL][HIP] Replace for loop to copy results with std::memcpy. #11779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2023
Merged

[SYCL][HIP] Replace for loop to copy results with std::memcpy. #11779

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 7 additions & 14 deletions sycl/include/sycl/ext/oneapi/matrix/matrix-hip.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,55 +344,48 @@ void joint_matrix_mad_hip(
*reinterpret_cast<const float16x4 *>(&A.wi_marray),
*reinterpret_cast<const float16x4 *>(&B.wi_marray),
*reinterpret_cast<const floatx4 *>(&C.wi_marray), 0, 0, 0);
for (int i = 0; i < 4; ++i)
D.wi_marray[i] = result[i];
std::memcpy(&D.wi_marray, &result, 4 * sizeof(float));
} else if constexpr (M == 32 && N == 32) {
auto result = __builtin_amdgcn_mfma_f32_32x32x8f16(
*reinterpret_cast<const float16x4 *>(&A.wi_marray),
*reinterpret_cast<const float16x4 *>(&B.wi_marray),
*reinterpret_cast<const floatx16 *>(&C.wi_marray), 0, 0, 0);
for (int i = 0; i < 16; ++i)
D.wi_marray[i] = result[i];
std::memcpy(&D.wi_marray, &result, 16 * sizeof(float));
}
} else if constexpr (std::is_same_v<Tm, bfloat16>) {
if constexpr (M == 16 && N == 16) {
auto result = __builtin_amdgcn_mfma_f32_16x16x16bf16_1k(
*reinterpret_cast<const bfloat16x4 *>(&A.wi_marray),
*reinterpret_cast<const bfloat16x4 *>(&B.wi_marray),
*reinterpret_cast<const floatx4 *>(&C.wi_marray), 0, 0, 0);
for (int i = 0; i < 4; ++i)
D.wi_marray[i] = result[i];
std::memcpy(&D.wi_marray, &result, 4 * sizeof(float));
} else if constexpr (M == 32 && N == 32) {
auto result = __builtin_amdgcn_mfma_f32_32x32x8bf16_1k(
*reinterpret_cast<const bfloat16x4 *>(&A.wi_marray),
*reinterpret_cast<const bfloat16x4 *>(&B.wi_marray),
*reinterpret_cast<const floatx16 *>(&C.wi_marray), 0, 0, 0);
for (int i = 0; i < 16; ++i)
D.wi_marray[i] = result[i];
std::memcpy(&D.wi_marray, &result, 16 * sizeof(float));
}
} else if constexpr (std::is_same_v<Tm, double>) {
if constexpr (M == 16 && N == 16) {
auto result = __builtin_amdgcn_mfma_f64_16x16x4f64(
A.wi_marray[0], B.wi_marray[0],
*reinterpret_cast<const doublex4 *>(&C.wi_marray), 0, 0, 0);
for (int i = 0; i < 4; ++i)
D.wi_marray[i] = result[i];
std::memcpy(&D.wi_marray, &result, 4 * sizeof(double));
}
} else if constexpr (std::is_same_v<Tm, int8_t>) {
if constexpr (M == 16 && N == 16) {
auto result = __builtin_amdgcn_mfma_i32_16x16x16i8(
*reinterpret_cast<const Tc *>(&A.wi_marray),
*reinterpret_cast<const Tc *>(&B.wi_marray),
*reinterpret_cast<const int32x4 *>(&C.wi_marray), 0, 0, 0);
for (int i = 0; i < 4; ++i)
D.wi_marray[i] = result[i];
std::memcpy(&D.wi_marray, &result, 4 * sizeof(int32_t));
} else if constexpr (M == 32 && N == 32) {
auto result = __builtin_amdgcn_mfma_i32_32x32x8i8(
*reinterpret_cast<const Tc *>(&A.wi_marray),
*reinterpret_cast<const Tc *>(&B.wi_marray),
*reinterpret_cast<const int32x16 *>(&C.wi_marray), 0, 0, 0);
for (int i = 0; i < 16; ++i)
D.wi_marray[i] = result[i];
std::memcpy(&D.wi_marray, &result, 16 * sizeof(int32_t));
}
}
}
Expand Down