[SYCL][DOC] Update sycl_ext_oneapi_prefetch#11835
Merged
againull merged 2 commits intointel:syclfrom Nov 10, 2023
Merged
Conversation
The compiler treats such code:
prefetch(ptr, 8)
as call to void prefetch(void *ptr, Properties properties = {}),
instead of void prefetch(T* ptr, size_t count, Properties properties = {});
Adding constraints to avoid this.
Contributor
Author
|
Not sure how this constraint should be added. Is it okay to add just like Note? |
Contributor
It should be added as a Constraints: paragraph on every function. For example, see how the
The Constraints: paragraph should precede Preconditions: and Effects:. |
gmlueck
approved these changes
Nov 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compiler treats such code:
prefetch(ptr, 8)
as call to void prefetch(void ptr, Properties properties = {}), instead of void prefetch(T ptr, size_t count, Properties properties = {});
Adding constraints to avoid this.