[Driver][SYCL] Do not emit target not found warning for early images #12035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly images For any objects/libraries created with -fno-sycl-rdc -c, we should not emit the 'linked binaries do not contain expected target' warning diagnostic. Expected use model is to not provide any specific targets to allow consuming of these objects/libraries.
mdtoguchi
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mdtoguchi
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mdtoguchi
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mdtoguchi
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
Author
|
@intel/dpcpp-clang-driver-reviewers, please take a look |
Contributor
Author
|
SYCL E2E on AWS CUDA failure is not related to this change |
hchilama
approved these changes
Dec 5, 2023
Contributor
Author
|
@intel/llvm-gatekeepers, the SYCL E2E on AWS CUDA failures are not associated with my change - can this be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For any objects/libraries created with -fno-sycl-rdc -c, we should not emit the 'linked binaries do not contain expected target' warning diagnostic. Expected use model is to not provide any specific targets to allow consuming of these objects/libraries.