[SYCL][ESIMD][E2E] Add DG2 unified memory block_load tests #12084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
v-klochkov
approved these changes
Dec 5, 2023
Contributor
v-klochkov
left a comment
v-klochkov
left a comment
There was a problem hiding this comment.
Looks very good!
BTW, I couldn't find anything (even a nit comment) to fix here.
Contributor
|
CUDA fails are unrelated to changes to E2E ESIMD tests. |
Contributor
Author
Wow, very unlikely for me to not make at least one mistake :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added DG2 versions of the block_load unified memory tests. I only did one type of test so we could discuss if this way of doing it is what we want to do.
I manually tested this on DG2 Linux and Windows and PVC Linux.