Skip to content

Conversation

@jinge90
Copy link
Contributor

@jinge90 jinge90 commented Feb 6, 2024

User can enable Asan for SYCL device code via -Xarch_device, we need to link Asan device library with user's device image in such case.

@jinge90 jinge90 requested a review from a team as a code owner February 6, 2024 03:33
@jinge90 jinge90 requested a review from mdtoguchi February 6, 2024 03:34
@jinge90
Copy link
Contributor Author

jinge90 commented Feb 6, 2024

Hi, @mdtoguchi
Could you help review this patch?
Thanks very much.

Signed-off-by: jinge90 <ge.jin@intel.com>
Copy link
Contributor

@mdtoguchi mdtoguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks!

@jinge90 jinge90 requested a review from a team February 7, 2024 00:32
@jinge90
Copy link
Contributor Author

jinge90 commented Feb 7, 2024

Hi, @intel/llvm-gatekeepers
Could you help merge this patch?
Thanks very much.

@sommerlukas sommerlukas merged commit 25dcc20 into intel:sycl Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants