[Driver][SYCL] Use LLVM-IR based device libraries for device linking #13524
Conversation
This change represents 2 changes.
1. Update the build to create LLVM-IR based device libraries.
This is done by using the existing -fsycl-device-only functionality to
create the device libraries that are used during device link.
2. Update the compiler driver to use the LLVM-IR based device
libraries.
When performing the device linking instead of performing a full unbundle
of the device libraries and using the device binary that was extracted.
This streamlines the device linking behaviors, completely removing the
cumbersome unbundling step from the process, freeing up a number of
exteral tool calls.
mdtoguchi
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
mdtoguchi
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
mdtoguchi
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
mdtoguchi
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
mdtoguchi
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
mdtoguchi
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
| C.MakeAction<OffloadAction>( | ||
| Dep, SYCLDeviceLibsUnbundleAction->getType()); | ||
| DeviceLinkObjects.push_back(SYCLDeviceLibsDependenciesAction); | ||
| if (TC->getTriple().isNVPTX()) { |
There was a problem hiding this comment.
Why do we need a separate path for NVPTX backend?
There was a problem hiding this comment.
There are specific cubin files that are in the fat objects that are used. I only created .bc device libraries for the SYCL specific linking.
|
Windows test fails might just require test update |
asudarsa
left a comment
asudarsa
left a comment
There was a problem hiding this comment.
Changes look good to me. It will help to get this checked in soon. One important pointer is the deviation for NVPTX backends. It will help to understand why we need that deviation and if it can be avoided.
Thanks
I have updated the windows tests accordingly and also consolidated the behaviors for input files as the inputs for Windows and Linux are both .bc files instead of differing object files. |
mdtoguchi
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
mdtoguchi
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
mdtoguchi
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
|
@intel/dpcpp-clang-driver-reviewers, could this be reviewed? |
4 participants
This change represents 2 changes.
This is done by using the existing -fsycl-device-only functionality to create the device libraries that are used during device link.
When performing the device linking instead of performing a full unbundle of the device libraries and using the device binary that was extracted.
This streamlines the device linking behaviors, completely removing the cumbersome unbundling step from the process, freeing up a number of exteral tool calls.