[SYCL] Enable gpu testing for aligned allocation functions after L0 bug fix #13631
Conversation
| // RUN: %{build} -o %t.out | ||
| // RUN: %{run} %t.out | ||
|
|
||
| //==----- alloc_with_invalid_alignment.cpp - SYCL USM allocation test-----==// |
There was a problem hiding this comment.
I don't think it is required to have a license boiler plate in tests, that's the case even with the upstream LLVM.
|
|
||
| #include <sycl/sycl.hpp> | ||
|
|
||
| // Purpose of this test is to verify that when SYCL is backed by L0, the aligned |
There was a problem hiding this comment.
We could simplify the wording. Something like:
"This test verifies that for L0 backend, aligned USM alloc functions returns null_ptr, when called with alignment values that are not a power-of-2. "
There was a problem hiding this comment.
Also, why just for L0 backend? What happens for opencl backend? If this test is supposed to run on a specific backend, it should have a "REQUIRES: opencl" or "REQUIRES:level_zero" statement
There was a problem hiding this comment.
There is a requires level_zero line in the first line of this file.
There was a problem hiding this comment.
Aahh.. I missed that. 👍🏻
|
Reminder to not merge this until the UR changes go through so that I can update the tag. |
lbushi25
changed the title
|
This pull request is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be automatically closed in 30 days. |
|
This pull request was closed because it has been stalled for 30 days with no activity. |
6 participants
I've opened a PR in UR oneapi-src/unified-runtime#1569 which has been merged, that fixes an issue where USM allocation functions are returning non-null pointer values when called with alignment values that are not powers of 2 on L0 devices. In this PR, I've re-enabled gpu testing on an E2E test that was trying to validate this behavior.