Skip to content

Conversation

@lbushi25
Copy link
Contributor

@lbushi25 lbushi25 commented May 27, 2024

This PR rewrites a few assertions in 3(HIP, OCL, CUDA) adapters to instead have them return error codes. This came up while writing this test(align.cpp), specifically, the test was triggering assertions while allocating aligned memory when running on various backends and this did not look right to me. In my opinion, it is not right to have a program whose behavior is completely defined by the SYCL spec randomly crash due to an assert. This may or may not be the right way to go about this, but either way, it gets the discussion going.

@github-actions github-actions bot added the level-zero L0 adapter specific issues label May 27, 2024
@lbushi25 lbushi25 changed the title [OpenCL] Remove opencl assertions [OpenCL] Remove opencl assertions in favor of returning error codes May 27, 2024
@lbushi25 lbushi25 marked this pull request as ready for review May 27, 2024 16:57
@lbushi25 lbushi25 requested a review from a team as a code owner May 27, 2024 16:57
@lbushi25
Copy link
Contributor Author

intel/llvm PR: intel/llvm#13631

@lbushi25 lbushi25 requested a review from a team as a code owner May 27, 2024 21:16
@lbushi25 lbushi25 requested a review from mmoadeli May 27, 2024 21:16
@github-actions github-actions bot added the hip HIP adapter specific issues label May 27, 2024
@lbushi25 lbushi25 changed the title [OpenCL] Remove opencl assertions in favor of returning error codes [OpenCL][HIP] Remove opencl assertions in favor of returning error codes May 27, 2024
@lbushi25 lbushi25 changed the title [OpenCL][HIP] Remove opencl assertions in favor of returning error codes [OpenCL][HIP] Remove opencl/hip assertions in favor of returning error codes May 27, 2024
@lbushi25 lbushi25 changed the title [OpenCL][HIP] Remove opencl/hip assertions in favor of returning error codes [OpenCL][HIP][CUDA] Remove opencl/hip assertions in favor of returning error codes May 28, 2024
@lbushi25 lbushi25 requested a review from a team as a code owner May 28, 2024 04:36
@github-actions github-actions bot added the cuda CUDA adapter specific issues label May 28, 2024
@lbushi25 lbushi25 changed the title [OpenCL][HIP][CUDA] Remove opencl/hip assertions in favor of returning error codes [OpenCL][HIP][CUDA] Remove plugin assertions in favor of returning error codes May 28, 2024
@kbenzie
Copy link
Contributor

kbenzie commented May 30, 2024

@lbushi25 I've put in a request to add you to the oneapi-src/unified-runtime-triage team so that GHA will kick off automatically on your PRs.

@martygrant
Copy link
Contributor

Unified Runtime -> intel/llvm Repo Move Notice

Information

The source code of Unified Runtime has been moved to intel/llvm under the unified-runtime top-level directory,
all future development will now be carried out there. This was done in intel/llvm#17043.

The code will be mirrored to oneapi-src/unified-runtime and the specification will continue to be hosted at oneapi-src.github.io/unified-runtime.

The contribution guide has been updated with new instructions for contributing to Unified Runtime.

PR Migration

All open PRs including this one will be labelled auto-close and shall be automatically closed after 30 days.
To allow for some breathing space, this automation will not be enabled until next week (27/02/2025).

Should you wish to continue with your PR you will need to migrate it to intel/llvm.
We have provided a script to help automate this process.


This is an automated comment.

@martygrant
Copy link
Contributor

Unified Runtime -> intel/llvm Repo Move Notice

Following on from the previous notice, we have now enabled workflows to automatically label and close PRs because the Unified Runtime source code has moved to intel/llvm.

This PR has now been marked with the auto-close label and will be automatically closed after 30 days.

Please review the previous notice for more information, including assistance with migrating your PR to intel/llvm.

Should there be a reason for this PR to remain open, manually remove the auto-close label.


This is an automated comment.

@github-actions
Copy link
Contributor

Automatic PR Closure Notice

Information

This PR has been closed automatically. It was marked with the auto-close label 30 days ago as part of the Unified Runtime source code migration to the intel/llvm repository - intel/llvm#17043.

All Unified Runtime development should be done in intel/llvm, details can be found in the updated contribution guide.
This repository will continue to exist as a mirror and will host the specification documentation.

Next Steps

Should you wish to re-open this PR it must be moved to intel/llvm. We have provided a script to help automate this process, otherwise no actions are required.


This is an automated comment.

@github-actions github-actions bot closed this Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-close cuda CUDA adapter specific issues hip HIP adapter specific issues level-zero L0 adapter specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants