[Driver][SYCL][NewOffloadModel] Hook up -fsycl-device-only behaviors #13672
Conversation
When using -fsycl-device-only with the new offloading model, update the behaviors to properly restrict the compilation flow to only produce the device binary. This more tightly integrates with the existing --offload-device-only option that is commonly used.
| StringRef ObjSuffix = isMSVCEnv ? ".obj" : ".o"; | ||
| StringRef NewObjSuffix = isMSVCEnv ? ".new.obj" : ".new.o"; | ||
| bool Ret = | ||
| (ObjFileName.starts_with("libsycl-") && |
There was a problem hiding this comment.
Is this going to deviate from the old-offloading-model flow where we do not seem to be calling Backend? If yes, is that agreeable? Thanks
There was a problem hiding this comment.
Yes, this is agreeable. The functionality is the same, we just introduce the additional phase to better match with the new model expectations.
|
Failures seem to be due to some infrastructure issue and unrelated to this change. |
|
Hi @mdtoguchi Can you please look at the cuda test fails? Thanks |
Cuda fails are unrelated to this PR and a fix has been submitted for review here: #13692 |
hdelan
left a comment
hdelan
left a comment
There was a problem hiding this comment.
Thanks for the ping. LGTM
|
@intel/llvm-gatekeepers, this looks ready for merge - thanks! |
5 participants
When using -fsycl-device-only with the new offloading model, update the behaviors to properly restrict the compilation flow to only produce the device binary. This more tightly integrates with the existing --offload-device-only option that is commonly used.