[NFC][SYCL] Relax the check in layout_exception #13748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In different version of glibc , we may get `struct` instead of `class`. To avoid noisy failures, we can remove the keyword check here.
sycl/test/abi/layout_exception.cpp
Outdated
| // CHECK-NEXT: 40 | class std::__shared_count<> _M_refcount | ||
| // CHECK-NEXT: 40 | _Sp_counted_base<(_Lock_policy)2U> * _M_pi | ||
| // CHECK-NEXT: 48 | class std::error_code MErrC | ||
| // CHECK-NEXT: std::error_code MErrC |
Contributor
There was a problem hiding this comment.
Can we instead do something like {{class|struct}} std::error_code... ?
Contributor
Author
There was a problem hiding this comment.
We can, but I don't think that will improve the testing, eg: we may fail again if there are some other keywords around it due to different env.
Contributor
There was a problem hiding this comment.
I think "48" is kind of important here because we do want to know the offsets and ensure it's unchanged for the purposes of ABI compatibility. I think @uditagarwal97 's initial suggestion is the way to go.
Contributor
Author
|
@intel/llvm-gatekeepers Please help to merge this. Thanks. |
1 similar comment
Contributor
Author
|
@intel/llvm-gatekeepers Please help to merge this. Thanks. |
uditagarwal97
approved these changes
May 13, 2024
aelovikov-intel
approved these changes
May 13, 2024
Contributor
Author
|
@intel/llvm-gatekeepers Please help to merge this. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In different version of glibc , we may get
structinstead ofclass.To avoid noisy failures, we can remove the keyword check here.