[SYCL][UR] Fix fetch adapter source cache variable #13934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This caused issues in local builds because if the specific adapter source is reset to the main UR checkout, the cache variable pointing to the adapter specific checkout would stick around, and the adapter would still be built from that older checkout which would eventually caused build failures.
aarongreig
approved these changes
May 28, 2024
kbenzie
approved these changes
May 28, 2024
Contributor
Author
|
@intel/llvm-gatekeepers this is ready to merge |
Contributor
|
Ping @intel/llvm-gatekeepers the build is broken without this patch. Please merge, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caused issues in local builds because if the specific adapter source is reset to the main UR checkout, the cache variable pointing to the adapter specific checkout would stick around, and the adapter would still be built from that older checkout which would eventually caused build failures.