[SYCL] Fix acos edge case #14026
Merged
[SYCL] Fix acos edge case #14026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KseniyaTikhomirova
approved these changes
Jun 7, 2024
|
|
||
| q.single_task([=] { | ||
| for (int i = 0; i < N; ++i) { | ||
| p[i] = std::acos(data[i][0]); |
Contributor
There was a problem hiding this comment.
Note: we do not guarantee that std::acos works in kernels. But we should be supporting ::cacos according to our docs.
Contributor
Author
There was a problem hiding this comment.
Interesting, it seems we are still testing the std::complex math functions in our testing though: https://github.com/intel/llvm/blob/sycl/sycl/test-e2e/DeviceLib/std_complex_math_fp64_test.cpp
Contributor
|
Windows pre-commit failed due to seemingly infrastructure issue and we had a clean run of it before merge commit here, so I will proceed with merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.