Skip to content

[SYCL] Fix acos edge case #14026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 2, 2024
Merged

[SYCL] Fix acos edge case #14026

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
666dc88
[SYCL] Fix acos edge case
jzc Jun 4, 2024
db34f57
Add requires aspect-fp64 to test
jzc Jun 4, 2024
b614fd2
formatting
jzc Jun 4, 2024
1125309
Merge remote-tracking branch 'intel/sycl' into libdevice-cacos-fix
jzc Jun 14, 2024
522ee60
Add unsupport cuda and hip
jzc Jun 14, 2024
9770e3a
Merge remote-tracking branch 'intel/sycl' into libdevice-cacos-fix
jzc Jul 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions libdevice/fallback-complex-fp64.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,8 +311,8 @@ double __complex__ __devicelib_cacos(double __complex__ z) {
return CMPLX(z_real, -z_imag);
return CMPLX(z_real, z_real);
}
if (__spirv_IsInf(z_real))
return CMPLX(__pi / 2.0, -z_real);
if (__spirv_IsInf(z_imag))
return CMPLX(__pi / 2.0, -z_imag);
if (z_real == 0 && (z_imag == 0 || __spirv_IsNan(z_imag)))
return CMPLX(__pi / 2.0, -z_imag);
double __complex__ w =
Expand Down
39 changes: 39 additions & 0 deletions sycl/test-e2e/Regression/acos.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
// REQUIRES: aspect-fp64
// UNSUPPORTED: cuda || hip

// RUN: %{build} -o %t.out
// RUN: %{run} %t.out
#include <complex>
#include <sycl/detail/core.hpp>
#include <sycl/usm.hpp>

using namespace sycl;
using T = std::complex<double>;

int main() {
queue q;
const double pi = std::atan2(+0., -0.);
T data[][2] = {{{-2, -INFINITY}, {pi / 2, INFINITY}},
{{-0., INFINITY}, {pi / 2, -INFINITY}}};
int N = std::size(data);
auto *p = malloc_shared<T>(N, q);

q.single_task([=] {
for (int i = 0; i < N; ++i) {
p[i] = std::acos(data[i][0]);
Copy link
Contributor

@AlexeySachkov AlexeySachkov Jun 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: we do not guarantee that std::acos works in kernels. But we should be supporting ::cacos according to our docs.

Copy link
Contributor Author

@jzc jzc Jun 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, it seems we are still testing the std::complex math functions in our testing though: https://github.com/intel/llvm/blob/sycl/sycl/test-e2e/DeviceLib/std_complex_math_fp64_test.cpp

}
}).wait();

int fails = 0;
for (int i = 0; i < N; ++i) {
auto actual = p[i];
auto expected = data[i][1];
if (expected != actual) {
std::cout << i << " fail:"
<< "expected = " << expected << ", actual = " << actual << "\n";
++fails;
}
}

return fails;
}