[SYCL] Add basic tests for virtual functions #14209
Conversation
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
AlexeySachkov
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
AlexeySachkov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
AlexeySachkov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
…ual-functions-basic-e2e-tests
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
…ual-functions-basic-e2e-tests
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
| sizeof(SubstractBy4), sizeof(SubstractBy4AndMultiplyBy4)}); | ||
|
|
||
| sycl::buffer<char> ObjStorage(sycl::range{Size}); | ||
| char HostStorage[Size]; |
There was a problem hiding this comment.
Do we need to set the alignment of these to correspond to some common alignment between the types we may place in it?
There was a problem hiding this comment.
Good question, I think we should indeed align the storage as well. basic.align.1 says:
Attempting to create an object ([intro.object]) in storage that does not meet the alignment requirements of the object's type is undefined behavior.
There was a problem hiding this comment.
Resolved in 04dda01
Main motivation is to make sure that storage for objects is properly aligned so there are no UBs when using placement new. It also allowed to simplify tests source code by outlining some common/similar object construction part into a helper.
…ual-functions-basic-e2e-tests
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
Failure in host task does not seem related, or I don't understand how adding new tests could lead to timeout on the old one (and that was per-test timeout, not per-suite). I've reported the failure in #14613 and will proceed with the merge |
| return nullptr; | ||
| } | ||
|
|
||
| return constructHelper<RetT, T...>(TypeIndex, 0); |
There was a problem hiding this comment.
I think something like
llvm/sycl/include/sycl/vector.hpp
Lines 1204 to 1209 in 8eeb60d
There was a problem hiding this comment.
TypeIndex is a runtime value here, the function is not constexpr.
Otherwise, I think I could have used tuple_element as built-in helper, essentially
UPD: looking at it more, TypeIndex being RT value shouldn't matter here. Checks are happening at runtime, only expansion happens at compile-time and list of types is known. I will take a deeper look to see if I can simplify this
AlexeySachkov
deleted the
private/asachkov/virtual-functions-basic-e2e-tests
branch
3 participants
Test plan is available in #10540