Skip to content

Conversation

@KornevNikita
Copy link
Contributor

No description provided.

@KornevNikita KornevNikita requested a review from a team as a code owner June 27, 2024 13:37
@KornevNikita
Copy link
Contributor Author

KornevNikita commented Jun 27, 2024

Will revert 37bddca if approved.
Example run: https://github.com/intel/llvm/actions/runs/9695615748

@KornevNikita
Copy link
Contributor Author

KornevNikita commented Jun 27, 2024

@KornevNikita
Copy link
Contributor Author

@KornevNikita
Copy link
Contributor Author

Renaming ext_oneapi_level_zero -> level_zero in: #14739
Will update this PR when 14739 is merged.

@KornevNikita
Copy link
Contributor Author

Renaming ext_oneapi_level_zero -> level_zero in: #14739 Will update this PR when 14739 is merged.

Updated with 3aff417. @aelovikov-intel do we need any additional runs?

@aelovikov-intel
Copy link
Contributor

Fresh run: https://github.com/intel/llvm/actions/runs/10059118880/job/27804689750

This failed, didn't it? We cannot add a "red" subtask.

@KornevNikita
Copy link
Contributor Author

Fresh run: https://github.com/intel/llvm/actions/runs/10059118880/job/27804689750

This failed, didn't it? We cannot add a "red" subtask.

Oh, yes. I think we need to have different cts_exclude_filter for different devices. Will try to introduce a new one.

@KornevNikita
Copy link
Contributor Author

@KornevNikita
Copy link
Contributor Author

@aelovikov-intel could you please take one more look.

Comment on lines +306 to +311
if [ "${{ contains(inputs.target_devices, 'opencl:cpu') }}" = "true" ]; then
cat $PWD/devops/cts_exclude_filter_OCL_CPU
fi
if [ "${{ contains(inputs.target_devices, 'level_zero:gpu') }}" = "true" ]; then
cat $PWD/devops/cts_exclude_filter_L0_GPU
fi
Copy link
Contributor

@aelovikov-intel aelovikov-intel Jul 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, we should drop this step and print that information after we've selected the right file. I'm ok if that will be done in another PR though.

@aelovikov-intel
Copy link
Contributor

Are post-commit failures known?

@KornevNikita
Copy link
Contributor Author

Are post-commit failures known?

Yes, as I understand the last PR mentioned in the comments here should fix that: #14280

@aelovikov-intel aelovikov-intel merged commit 13d05bd into sycl Jul 25, 2024
@aelovikov-intel aelovikov-intel deleted the nightly-sycl-cts-gpu branch July 25, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants