[SYCL] Add support for optional kernel features in AOT x86_64 compilation #14590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarnex
reviewed
Jul 16, 2024
| // REQUIRES: ocloc, opencl-aot | ||
| // RUN: %clangxx -fsycl -fsycl-targets=intel_gpu_tgllp -o %t.tgllp.out %s | ||
| // RUN: %clangxx -fsycl -fsycl-targets=intel_gpu_cfl -o %t.cfl.out %s | ||
| // RUN: %clangxx -fsycl -fsycl-targets=spir64_x86_64 -o %t.x86.out %s |
Contributor
Contributor
There was a problem hiding this comment.
Also REQUIRES: opencl-aot
sycl/test-e2e/AOT/half.cpp
Outdated
|
|
||
| // REQUIRES: ocloc, opencl-aot | ||
| // RUN: %clangxx -fsycl -fsycl-targets=intel_gpu_tgllp -o %t.tgllp.out %s | ||
| // RUN: %clangxx -fsycl -fsycl-targets=intel_gpu_cfl -o %t.cfl.out %s |
Contributor
There was a problem hiding this comment.
Can you please apply a similar fix that I have proposed in #14588, as written this will fail on Windows once I enable windows aot.
| // REQUIRES: ocloc, opencl-aot | ||
| // RUN: %clangxx -fsycl -fsycl-targets=intel_gpu_tgllp -o %t.tgllp.out %s | ||
| // RUN: %clangxx -fsycl -fsycl-targets=intel_gpu_cfl -o %t.cfl.out %s | ||
| // RUN: %clangxx -fsycl -fsycl-targets=spir64_x86_64 -o %t.x86.out %s |
Contributor
There was a problem hiding this comment.
same question about REQUIRES
mdtoguchi
reviewed
Jul 16, 2024
sarnex
approved these changes
Jul 17, 2024
Contributor
sarnex
left a comment
sarnex
left a comment
There was a problem hiding this comment.
my flags are resolved, thanks!
mdtoguchi
approved these changes
Jul 17, 2024
Contributor
|
BTW I finally enabled Windows AOT in our CI, if you want to have the best testing I recommend merging sycl/HEAD and letting tests run, in the Windows Gen12 logs you should see and that means it's working Thanks and sorry for the trouble |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.