[SYCL][COMPAT] Enabled device_info caching within device_ext #14630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OuadiElfarouki
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
OuadiElfarouki
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Alcpz
suggested changes
Jul 19, 2024
OuadiElfarouki
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
OuadiElfarouki
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
OuadiElfarouki
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
OuadiElfarouki
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
OuadiElfarouki
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
OuadiElfarouki
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
OuadiElfarouki
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
OuadiElfarouki
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Alcpz
approved these changes
Jul 29, 2024
Contributor
Alcpz
left a comment
Alcpz
left a comment
There was a problem hiding this comment.
LGTM, thanks for the changes.
OuadiElfarouki
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
OuadiElfarouki
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
Author
|
@intel/llvm-gatekeepers Should be good to go! Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces a simple memoization mechanism within
device_extby caching thedevice_info, which helps avoid redundant/unnecessary queries of the full device infos whenever a single device info (max_wg_sizefor e.g.) is requested.API Tests in
device_ext_apihave been slightly modified to verify some of the expected new changes toget_device_infomethods.