[SYCL][E2E] Add -Werror flag to sycl e2e tests
#14689
Conversation
| @@ -1,5 +1,5 @@ | |||
| // REQUIRES: opencl | |||
| // RUN: %{build} -o %t.out | |||
| // RUN: %{build} -std=c++20 -o %t.out | |||
There was a problem hiding this comment.
This warning is generated without it:
# .---command stderr------------
# | /localdisk2/dgarciao/llvm/sycl/test-e2e/Regression/check_vector_of_opencl_event.cpp:21:38: warning: use of function template name with no prior declaration in function call with explicit template arguments is a C++20 extension [-Wc++20-extensions]
# | 21 | std::vector<cl_event> ClEventVec = get_native<sycl::backend::opencl>(event);
# | | ^
# | 1 warning generated.
# | /localdisk2/dgarciao/llvm/sycl/test-e2e/Regression/check_vector_of_opencl_event.cpp:21:38: warning: use of function template name with no prior declaration in function call with explicit template arguments is a C++20 extension [-Wc++20-extensions]
# | 21 | std::vector<cl_event> ClEventVec = get_native<sycl::backend::opencl>(event);
# | | ^
# | 1 warning generated.
# \`-----------------------------
There was a problem hiding this comment.
Folks this is the wrong way to fix this warning. The test is not supposed to use C++20 features.
Please replace get_native<sycl::backend::opencl>(event) to sycl::get_native<sycl::backend::opencl>(event) at line 20.
@maarquitos14 |
It's definitely a good idea. On a side note, just wondering if having tests for deprecated functionalities makes sense or those should be dropped. |
Should fix the errors on ARC
|
@intel/unified-runtime-reviewers Friendly ping. |
8 participants
This patch adds the
-Werrorflag to all SYCL e2e tests to stop the introduction of new warnings.Added
-Wno-error=to existing tests that have warnings (Or made changes to resolve the warnings).