[SYCL] Fix race condition in EnqueueNativeCommand #14717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarnex
approved these changes
Jul 23, 2024
Contributor
sarnex
left a comment
sarnex
left a comment
There was a problem hiding this comment.
lgtm in terms of i think it should fix the nightly failure. we should have a seperate tracker to fix the root cause and reenable this case
Contributor
Author
Yep I'm investigating as we speak |
Contributor
|
thx |
Wrong command type was being used, causing code to follow host task codepath. This fixes that.
Contributor
Author
|
@sarnex bug found. See update |
Contributor
|
thanks! im not qualified to review this fix but i really appreciate the quick investigation and root cause fix! |
hdelan
changed the title
Copy the CodeplayHostTask command in how to get the context.
cperkinsintel
requested review from
sergey-semenov
and removed request for
sergey-semenov
cperkinsintel
approved these changes
Jul 25, 2024
bso-intel
approved these changes
Jul 25, 2024
AlexeySachkov
pushed a commit
to AlexeySachkov/llvm
that referenced
this pull request
Nov 26, 2024
Wrong command type was being used for enqueue native command, causing a race condition as the host task codepath was being taken, where another path should have been taken. This fixes intel#14715 @sarnex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrong command type was being used for enqueue native command, causing a race condition as the host task codepath was being taken, where another path should have been taken. This fixes #14715
@sarnex