Skip to content

Conversation

@bader
Copy link
Contributor

@bader bader commented Jul 24, 2024

According to release notes the extension was implemented by
e7139b0,
0229456
and
b5d69df

According to release notes the extension was implemented by
intel@e7139b0,
intel@0229456
and
intel@b5d69df
@bader bader requested a review from a team as a code owner July 24, 2024 02:14
@bader bader requested a review from KornevNikita July 24, 2024 02:15
@bader
Copy link
Contributor Author

bader commented Jul 24, 2024

@KornevNikita, did I get it right that this extension is implemented?

@KornevNikita
Copy link
Contributor

@bader should we have cts to mark it as supported?

@bader
Copy link
Contributor Author

bader commented Jul 24, 2024

I believe we do not have such a requirement. @gmlueck?

@gmlueck
Copy link
Contributor

gmlueck commented Jul 24, 2024

I believe we do not have such a requirement. @gmlueck?

No, it is sufficient to have e2e tests in our own repo, and it looks like we did this in #11834.

However, there are two problems with the spec change in this PR:

  • This extension is "experimental" not "supported", so it's in the wrong directory.
  • The Status section text should be updated to note that it is "experimental". See the template for the right wording.

Also, I don't see any definition of the feature-test macro SYCL_EXT_ONEAPI_PREFETCH.

@bader
Copy link
Contributor Author

bader commented Jul 24, 2024

However, there are two problems with the spec change in this PR:

  • This extension is "experimental" not "supported", so it's in the wrong directory.
  • The Status section text should be updated to note that it is "experimental". See the template for the right wording.

Fixed.

Also, I don't see any definition of the feature-test macro SYCL_EXT_ONEAPI_PREFETCH.

It's here -> https://github.com/intel/llvm/blob/sycl/sycl/source/feature_test.hpp.in#L100

Copy link
Contributor

@gmlueck gmlueck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I don't see any definition of the feature-test macro SYCL_EXT_ONEAPI_PREFETCH.

It's here -> https://github.com/intel/llvm/blob/sycl/sycl/source/feature_test.hpp.in#L100

Oh, sorry. I just searched the "sycl/include" directory.

…idoc

Co-authored-by: Greg Lueck <gregory.m.lueck@intel.com>
@bader bader merged commit c79c3df into intel:sycl Jul 30, 2024
@bader bader deleted the prefetch branch July 30, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants