[sycl-post-link] Fix spec constant pattern match for DeviceSanitizer #14740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust spec constant pattern match for base alloca + offset case in device sanitizer. Address sanitizer merges static allocas into a large layout base alloca and original alloca is replaced with base + offset.
Contributor
Author
|
kindly ping @intel/dpcpp-tools-reviewers for review |
1 similar comment
Contributor
Author
|
kindly ping @intel/dpcpp-tools-reviewers for review |
AlexeySachkov
approved these changes
Aug 1, 2024
Contributor
AlexeySachkov
left a comment
AlexeySachkov
left a comment
There was a problem hiding this comment.
Apology for the delay
| MODULE_PASS("record-sycl-aspect-names", RecordSYCLAspectNamesPass()) | ||
| MODULE_PASS("sycl-virtual-functions-analysis", | ||
| SYCLVirtualFunctionsAnalysisPass()) | ||
| MODULE_PASS("spec-constants", SpecConstantsPass()) |
Contributor
There was a problem hiding this comment.
Thanks! Most of pass tests use incorrect approach with testing it through sycl-post-link, this is a way better direction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust spec constant pattern match for base alloca + offset case in device sanitizer.
Address sanitizer merges static allocas into a large layout base alloca and original alloca is replaced with base + offset.