[SYCL] Rename sycl-fusion to sycl-jit #14762
Conversation
jchlanda
force-pushed
the
jakub/fusion_rename
branch
from
c0d72f5 to
fb7958d
Compare
jchlanda
force-pushed
the
jakub/fusion_rename
branch
from
920b0c3 to
da0674e
Compare
jchlanda
changed the title
jchlanda
force-pushed
the
jakub/fusion_rename
branch
from
da0674e to
544f175
Compare
|
This is a follow up from the #14280 where the library/directory rename was discussed. |
This patch renames the directory (`sycl-fusion` to `sycl-jit`) as well as the involved library names (following the same principle: `fusion` to `jit`). To keep the user facing names consistent buildbot switches were updated. And finally the codeowners file had to reflect the directory change.
|
Code formatting is failing bad for this patch, but I'm not sure if it should be trusted, seems like it's in python files which have never been formatted in the first place, for instance conifgure.py. |
sommerlukas
left a comment
sommerlukas
left a comment
There was a problem hiding this comment.
One minor nit about capitalization.
There's also a few things missing that should be renamed, e.g., the CMake option SYCL_ENABLE_KERNEL_FUSION and related options. Potentially also macros should be renamed, while preserving feature test macros from the extension with the name specified by the extension.
sycl-jit/passes/CMakeLists.txt
Outdated
| @@ -1,5 +1,5 @@ | |||
| # Module library for usage as library/pass-plugin with LLVM opt. | |||
| add_llvm_library(SYCLKernelFusion MODULE | |||
| add_llvm_library(SYCLKernelJit MODULE | |||
There was a problem hiding this comment.
Should we maintain capitalization of "JIT" here, i.e., SYCLKernelJIT?
There was a problem hiding this comment.
Agreed, will apply the same logic to SYCLKerneJitPasses.
jchlanda
force-pushed
the
jakub/fusion_rename
branch
from
f8f2272 to
1608b4b
Compare
gmlueck
left a comment
gmlueck
left a comment
There was a problem hiding this comment.
Change to Getting Started Guide LGTM.
sommerlukas
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sommerlukas
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
This patch renames the directory (`sycl-fusion` to `sycl-jit`) as well as the involved library names (following the same principle: `fusion` to `jit`). To keep the user facing names consistent, buildbot switches were updated. And finally the codeowners file had to reflect the directory change.
11 participants
This patch renames the directory (
sycl-fusiontosycl-jit) as wellas the involved library names (following the same principle:
fusiontojit).To keep the user facing names consistent buildbot switches were updated.
And finally the codeowners file had to reflect the directory change.