Skip to content

[NFC] fix build issue in NDEBUG mode #14777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 25, 2024
Merged

[NFC] fix build issue in NDEBUG mode #14777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67f1071
[NFC] fix build issue in NDEBUG mode
Jul 25, 2024
a0ea9a6
fix macos
Jul 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions sycl-fusion/jit-compiler/lib/translation/KernelTranslation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,8 @@ KernelTranslator::translateToSPIRV(llvm::Module &Mod, JITContext &JITCtx) {

llvm::Expected<KernelBinary *> KernelTranslator::translateToPTX(
SYCLKernelInfo &KernelInfo, llvm::Module &Mod, JITContext &JITCtx,
const std::string &TargetCPU, const std::string &TargetFeatures) {
[[maybe_unused]] const std::string &TargetCPU,
[[maybe_unused]] const std::string &TargetFeatures) {
#ifndef FUSION_JIT_SUPPORT_PTX
(void)KernelInfo;
(void)Mod;
Expand Down Expand Up @@ -310,7 +311,8 @@ llvm::Expected<KernelBinary *> KernelTranslator::translateToPTX(

llvm::Expected<KernelBinary *> KernelTranslator::translateToAMDGCN(
SYCLKernelInfo &KernelInfo, llvm::Module &Mod, JITContext &JITCtx,
const std::string &TargetCPU, const std::string &TargetFeatures) {
[[maybe_unused]] const std::string &TargetCPU,
[[maybe_unused]] const std::string &TargetFeatures) {
#ifndef FUSION_JIT_SUPPORT_AMDGCN
(void)KernelInfo;
(void)Mod;
Expand Down
2 changes: 2 additions & 0 deletions sycl-fusion/passes/kernel-fusion/SYCLSpecConstMaterializer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,9 @@ PreservedAnalyses SYCLSpecConstMaterializer::run(Function &F,
if (const char *DebugEnv = std::getenv("SYCL_JIT_COMPILER_DEBUG"))
if (strstr(DebugEnv, DEBUG_TYPE)) {
DebugFlag = true;
#ifndef NDEBUG
llvm::setCurrentDebugType(DEBUG_TYPE);
#endif
}

Mod = F.getParent();
Expand Down