[ESIMD] Move spirv global translation out of the function processing to improve compilation time #14786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarnex
approved these changes
Jul 29, 2024
Comment on lines
2095
to
2097
| for (User *U : Global.users()) { | ||
| translateGlobalUse(U, Global.getName().drop_front(PrefLen), ToErase); | ||
| } |
There was a problem hiding this comment.
nit: remove braces from loop since it's one line
| translateGlobalUse(U, Global.getName().drop_front(PrefLen), ToErase); | ||
| } | ||
| } | ||
| for (auto *CI : ToErase) { |
| } | ||
| } | ||
|
|
||
| static void translateGlobalUse(Value *Use, StringRef SpirvGlobalName, |
There was a problem hiding this comment.
just wondering, how did this issue come up? do we have an internal tracker for it?
There was a problem hiding this comment.
It is nice to have suggestion for original work to lower spirv globals from ~ 3 years ago. Theoretically it should improve compilation performance and reduce amount of code, but I doubt anybody will notice that. It was included into tracker to move ESIMD passes/split LowerESIMD pass to Function Passes
|
@intel/llvm-gatekeepers Could you please merge this patch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.