[DeviceSaniitizer] Force outline call for setting private shadow memory #14818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, address sanitizer will inline call for setting private shadow memory with small size. However, if work group size is too large, the private shadow memory may allocate failed. We need to check if shadow base is null before trying to poison it.
yingcong-wu
approved these changes
Jul 29, 2024
AllanZyne
reviewed
Jul 29, 2024
AllanZyne
reviewed
Jul 29, 2024
zhaomaosu
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
zhaomaosu
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
AllanZyne
approved these changes
Jul 30, 2024
wenju-he
reviewed
Jul 30, 2024
llvm/test/Instrumentation/AddressSanitizer/SPIRV/instrument_private_address_space.ll
Show resolved
Hide resolved
AllanZyne
reviewed
Jul 30, 2024
sycl/test-e2e/AddressSanitizer/out-of-bounds/USM/large_group_size.cpp
Outdated
Show resolved
Hide resolved
…ize.cpp Co-authored-by: Yang Zhao <allanzyne@outlook.com>
zhaomaosu
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
|
Hi @intel/llvm-gatekeepers, this PR is ready to be merged. And pre-ci failures are unrelated to this change. |
|
Hi @intel/llvm-gatekeepers, could you please help merge this PR? Thanks. |
|
@zhaomaosu This PR failed in post-commit, can you take a look if the failure is related to your changes: Specifically: |
|
Hi @sommerlukas, I believe this failure is unrelated to my change. My change only affect device sanitizer. And the failed test doesn't use device sanitizer. |
|
Reported the unrelated failure in #14863 |
AlexeySachkov
pushed a commit
to AlexeySachkov/llvm
that referenced
this pull request
Nov 26, 2024
…ry (intel#14818) By default, address sanitizer will inline call for setting private shadow memory with small size. However, if work group size is too large, the private shadow memory may allocate failed. We need to check if shadow base is null before trying to poison it. --------- Co-authored-by: Yang Zhao <allanzyne@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, address sanitizer will inline call for setting private shadow memory with small size. However, if work group size is too large, the private shadow memory may allocate failed. We need to check if shadow base is null before trying to poison it.