Skip to content

Conversation

@dkhaldi
Copy link
Contributor

@dkhaldi dkhaldi commented Jul 29, 2024

No description provided.

@dkhaldi dkhaldi requested a review from a team as a code owner July 29, 2024 15:36
Copy link
Contributor

@YuriPlyakhin YuriPlyakhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@YuriPlyakhin YuriPlyakhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dkhaldi dkhaldi temporarily deployed to WindowsCILock July 30, 2024 16:03 — with GitHub Actions Inactive
@dkhaldi
Copy link
Contributor Author

dkhaldi commented Jul 30, 2024

@intel/llvm-gatekeepers, please help merge.

@sommerlukas sommerlukas merged commit a66958b into intel:sycl Jul 31, 2024
@sommerlukas
Copy link
Contributor

@dkhaldi

There was one unexpectedly passing test on post-commit CI for this PR:

Unexpectedly Passed Tests (1):
  SYCL :: Matrix/SG32/joint_matrix_prefetch.cpp

Can you or someone from @intel/sycl-matrix-reviewers please take care of that?

https://github.com/intel/llvm/actions/runs/10175843701/job/28144675804

@dkhaldi
Copy link
Contributor Author

dkhaldi commented Jul 31, 2024

@dkhaldi

There was one unexpectedly passing test on post-commit CI for this PR:

Unexpectedly Passed Tests (1):
  SYCL :: Matrix/SG32/joint_matrix_prefetch.cpp

Can you or someone from @intel/sycl-matrix-reviewers please take care of that?

https://github.com/intel/llvm/actions/runs/10175843701/job/28144675804

Thanks, this is being fixed in #14866

@dkhaldi dkhaldi deleted the rm-pref-xfail branch July 31, 2024 15:40
@uditagarwal97
Copy link
Contributor

@dkhaldi
Matrix/joint_matrix_prefetch.cpp is failing on PVC without dev igc: https://github.com/intel/llvm/actions/runs/10182714951/job/28223556749?pr=14720#step:22:137

********************
FAIL: SYCL :: Matrix/joint_matrix_prefetch.cpp (1507 of 2131)
******************** TEST 'SYCL :: Matrix/joint_matrix_prefetch.cpp' FAILED ********************
Exit Code: -11

Command Output (stdout):
--
# RUN: at line 9
/__w/llvm/llvm/toolchain/bin//clang++ -Werror  -fsycl -fsycl-targets=spir64  /__w/llvm/llvm/llvm/sycl/test-e2e/Matrix/joint_matrix_prefetch.cpp -o /__w/llvm/llvm/build-e2e/Matrix/Output/joint_matrix_prefetch.cpp.tmp.out
# executed command: /__w/llvm/llvm/toolchain/bin//clang++ -Werror -fsycl -fsycl-targets=spir64 /__w/llvm/llvm/llvm/sycl/test-e2e/Matrix/joint_matrix_prefetch.cpp -o /__w/llvm/llvm/build-e2e/Matrix/Output/joint_matrix_prefetch.cpp.tmp.out
# note: command had no output on stdout or stderr
# RUN: at line 10
env ONEAPI_DEVICE_SELECTOR=level_zero:gpu  /__w/llvm/llvm/build-e2e/Matrix/Output/joint_matrix_prefetch.cpp.tmp.out
# executed command: env ONEAPI_DEVICE_SELECTOR=level_zero:gpu /__w/llvm/llvm/build-e2e/Matrix/Output/joint_matrix_prefetch.cpp.tmp.out
# note: command had no output on stdout or stderr
# error: command failed with exit status: -11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants