[SYCL][Bindless] Image Array Sub-Region Copy #14954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add support for sub-region copies of image arrays. * Initial implementation of tests.
DBDuncan
approved these changes
Aug 6, 2024
Contributor
Author
|
@intel/llvm-reviewers-runtime @dm-vodopyanov friendly ping. |
dm-vodopyanov
approved these changes
Aug 9, 2024
Contributor
dm-vodopyanov
left a comment
dm-vodopyanov
left a comment
There was a problem hiding this comment.
Note to gatekeepers: PR should be merged only after:
- oneapi-src/unified-runtime#1928 is merged
sycl/cmake/modules/FetchUnifiedRuntime.cmakehasUNIFIED_RUNTIME_REPOwhich points to the official repo (in oneapi-src), and not a fork
sycl/doc/extensions/experimental/sycl_ext_oneapi_bindless_images.asciidoc
Outdated
Show resolved
Hide resolved
* Make doc more explicit about sub-region extents.
przemektmalon
approved these changes
Aug 10, 2024
* Imporve clarity of sub-region copies outlined in spec.
isaacault
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
* Imporve clarity of sub-region copies in spec.
isaacault
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Seanst98
approved these changes
Aug 12, 2024
isaacault
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
isaacault
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
isaacault
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cppchedy
approved these changes
Aug 27, 2024
isaacault
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
isaacault
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
isaacault
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
isaacault
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
Author
|
CI failure unrelated. Tracked with #15341 . |
isaacault
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
isaacault
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
|
@isaacault UR PR merged, please resolve the conflicts and update UR tag, Thanks! |
isaacault
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
isaacault
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
|
@intel/llvm-gatekeepers Please merge, failure is unrelated. Thanks! |
omarahmed1111
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UR PR: oneapi-src/unified-runtime#1928