-
Notifications
You must be signed in to change notification settings - Fork 796
[SYCL] Start to move attribute handling to SemaSYCL #14955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This better reflects how Sema is organized upstream, following recent restructuring. Doing all of it at once (moving *all* SYCL-related code out of SemaDeclAttr) results in an unwieldy diff, interleaving additions and deletions in an unreadable way. Thus the patch is split up into parts for better reviewability.
elizabethandrews
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this. I believe @premanandrao was/is also taking a look at this. He is OOO till Monday. So if you are alright with waiting for this patch to be merged, I would like him to comment as well.
smanna12
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for the improvements.
ping, @premanandrao - thanks! |
Thanks for the ping. @elizabethandrews also pinged me on this change. Thanks! I like the changes and the split to the new file. |
premanandrao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve the conflicts, but LGTM.
Thanks for the review. Yeah I fixed conflicts yesterday and it's already conflicting again. It will be good to flush this PR. |
|
@intel/llvm-gatekeepers this is good to merge, thank you! |
This completes the work started by intel#14955.
This completes the work started by #14955.
This better reflects how Sema is organized upstream, following recent restructuring. Doing all of it at once (moving all SYCL-related code out of SemaDeclAttr) results in an unwieldy diff, interleaving additions and deletions in an unreadable way. Thus the patch is split up into parts for better reviewability.
Code has been moved to a new cpp file -
SemaSYCLAttrDecl.cpp- asSemaSYCL.cppis already large.