[SYCL] Remove -full-main-file-name and -fsycl-use-main-file-name options. #15072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zahiraam
changed the title
Contributor
Author
|
@stevemerr I have done some local test including the one I mentioned to you offline and it's passing. I think it would be nice to have you test full DBG testing to see if this change works for you. Thanks. |
Contributor
elizabethandrews
left a comment
elizabethandrews
left a comment
There was a problem hiding this comment.
FE cleanup looks ok to me. However, I am not very familiar with this functionality. Please wait for approval from @premanandrao and/or someone from the debug team
smanna12
approved these changes
Sep 3, 2024
Contributor
Author
|
@premanandrao Can you please review this? Thanks. |
Contributor
Author
|
@intel/llvm-gatekeepers Can this be merged please? Thanks. |
iclsrc
pushed a commit
that referenced
this pull request
Oct 14, 2025
Added Pattern for lowering `Math::ClampFOp` to `ROCDL::FMED3`. Also added `chipset` option to `MathToRocdl` pass to check for arch support ISA instructions Solves [#15072](llvm/llvm-project#157052) Reapplies llvm/llvm-project#160100 --------- Signed-off-by: Keshav Vinayak Jha <keshavvinayakjha@gmail.com>
iclsrc
pushed a commit
that referenced
this pull request
Oct 17, 2025
Added Pattern for lowering `Math::ClampFOp` to `ROCDL::FMED3`. Also added `chipet` option to `MathToRocdl` pass to check for arch support ISA instructions Solves [#15072](llvm/llvm-project#157052) Reapplies llvm/llvm-project#160100 Un-reverts the merged llvm/llvm-project#163259, and fixes the error. --------- Signed-off-by: Keshav Vinayak Jha <keshavvinayakjha@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two options were implemented to solve two issues (missing
checksumfor the main file on Windows and host compilationDICompileUnitpointing to a temporary file instead of the original source file). The introduction of the-include-footersolves these issues. These options can now be removed.