[SYCL][E2E] Remove leaking part of non-uniform-wk-gp-test #15112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As shown in intel#15111, currently sycl::stream will leak resources if an exception is thrown during launch of its associated command. This was in turn causing sycl/test-e2e/Basic/diagnostics/non-uniform-wk-gp-test.cpp to leak resources simply because it was using the stream in its testing. However, since the kernel should never execute, the stream did not serve a fundamental function in the test and was only there for additional debugging information in the case where the test would fail. As such, it is arguably better to improve coverage than to disable cases because of some potentially helpful additional output in the failing case. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As shown in #15111, currently sycl::stream will leak resources if an exception is thrown during launch of its associated command. This was in turn causing sycl/test-e2e/Basic/diagnostics/non-uniform-wk-gp-test.cpp to leak resources simply because it was using the stream in its testing. However, since the kernel should never execute, the stream did not serve a fundamental function in the test and was only there for additional debugging information in the case where the test would fail. As such, it is arguably better to improve coverage than to disable cases because of some potentially helpful additional output in the failing case.