Skip to content

Conversation

@sarnex
Copy link
Contributor

@sarnex sarnex commented Aug 26, 2024

It's fixed in a newer driver, same driver version. Not used in CI yet.

Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
@sarnex sarnex marked this pull request as ready for review August 27, 2024 14:36
@sarnex sarnex requested a review from a team as a code owner August 27, 2024 14:36
@fineg74
Copy link
Contributor

fineg74 commented Aug 27, 2024

2 questions
Do you need to update the required driver version for fix for double ?
Is this going to work on gen12 in CI with double ?

@sarnex
Copy link
Contributor Author

sarnex commented Aug 27, 2024

@fineg74 thanks for the review

Do you need to update the required driver version for fix for double ?

No, using the internal driver both versions are the same, IGC changed but that is only part of the entire driver, I think the version is from the runtime not IGC. If there is a problem I'll fix the driver version when we get the driver in CI.

Is this going to work on gen12 in CI with double ?

No, the double test guarded by a fp64 aspect check which is false on gen12.

Thanks

@sarnex sarnex merged commit 9eaca2b into intel:sycl Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants