[SYCL][E2E] P2P must use Device USM, not Shared #15242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aelovikov-intel
requested review from
JackAKirk and
uditagarwal97
and removed request for
uditagarwal97
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Contributor
Author
|
Windows task failed at |
Contributor
Author
|
I haven't done anything like that ("removed request"), @uditagarwal97 , please continue with the review :) |
| } | ||
|
|
||
| int *d_sum = malloc_shared<int>(1, Queues[0]); | ||
| int *d_sum = malloc_device<int>(1, Queues[0]); |
Contributor
There was a problem hiding this comment.
Should we first check if malloc_device is even supported on the device? Like:
if (dev.get_info<info::device::usm_device_allocations>())
...
Contributor
Author
There was a problem hiding this comment.
That would be a separate change - we're already using it on the next line.
Contributor
There was a problem hiding this comment.
@JackAKirk Please update this test (and other P2P tests, if applicable) to also check if device allocations are supported on the device(s).
uditagarwal97
approved these changes
Aug 30, 2024
JackAKirk
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #14095 (comment).