[SYCL][NFC] Rename support dynamic linking #15258
Conversation
LU-JOHN
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
LU-JOHN
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
LU-JOHN
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
LU-JOHN
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
There was a problem hiding this comment.
based on the description of the help option, the name allow-device-image-dependencies is more clear to me, allow-device-dependencies isn't too clear.
There was a problem hiding this comment.
The clang level option to control this behavior is -fsycl-allow-device-dependencies. Should we be consistent with the clang option or make the option name clearer?
There was a problem hiding this comment.
The clang option name is unclear to me too, but if we already went through the options working group and they approved it then it's fine to match it here.
There was a problem hiding this comment.
Should we be consistent with the clang option or make the option name clearer?
I don't think that we have to 100% match here. device-dependencies does not look entirely clear to me. I won't strongly object, but my preference is to have clearer name, even if it is different from clang one.
I would rather talk to options wg once again to change public name as well to device-image-dependencies or device-code-dependencies
There was a problem hiding this comment.
I'll ask the options WG.
There was a problem hiding this comment.
Should we try to change the option name for 2025.0, since it is a new option, or add a synonymous option name -fsycl-allow-device-image-dependencies for 2025.1 ?
There was a problem hiding this comment.
Definitely too late for 2025.0, we would have to deprecate and add the new option moving forward with 2025.1
asudarsa
left a comment
asudarsa
left a comment
There was a problem hiding this comment.
Looks good except for option name. Will approve once name is updated. Thanks much
…-device-dependencies Signed-off-by: Lu, John <john.lu@intel.com>
Signed-off-by: Lu, John <john.lu@intel.com>
LU-JOHN
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
LU-JOHN
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Changed to -allow-device-image-dependencies in sycl-post-link. Clang option will be changed to -fsycl-allow-device-image-dependencies when options WG approves. |
5 participants
Rename sycl-post-link option "-support-dynamic-linking" to "-allow-device-image-dependencies". This is consistent with the clang option that is tied to this sycl-post-link option, and is also consistent with what is being done inside sycl-post-link.