[SYCL][COMPAT] Move clashing functions into anonymous namespace #15446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some syclcompat:: functions clash with global namespace (C-style) functions because of Argument Dependent Lookup. These are: - memcpy - memset - free To prevent ADL from finding syclcompat:: funcs, they have beeen moved into an anonymous namespace.
joeatodd
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
joeatodd
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Malloc doesn't belong in the anonymous namespace
joeatodd
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
Nit: I'm not entirely certain what's our policy with headers (Licence etc.) for new files. Other than that LGTM |
Alcpz
approved these changes
Sep 20, 2024
joeatodd
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
joeatodd
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
joeatodd
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
joeatodd
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
ziranzha
reviewed
Oct 14, 2024
|
@intel/llvm-gatekeepers this is ready to merge 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some
syclcompat::functions clash with global namespace (C-style) functions because of Argument Dependent Lookup.These are:
memcpymemsetfreefillTo prevent ADL from finding these functions, they have been moved into an anonymous namespace.