Skip to content

Conversation

@MrSidims
Copy link
Contributor

@MrSidims MrSidims commented Sep 25, 2024

Also outline MatrixOperands calculation into a separate function.

Signed-off-by: Sidorov, Dmitry <dmitry.sidorov@intel.com>
Signed-off-by: Sidorov, Dmitry <dmitry.sidorov@intel.com>
Copy link
Contributor

@dkhaldi dkhaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@YuriPlyakhin YuriPlyakhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MrSidims MrSidims requested review from a team and dkhaldi October 7, 2024 20:15
@MrSidims
Copy link
Contributor Author

MrSidims commented Oct 7, 2024

@intel/llvm-gatekeepers can we merge this please?

Copy link
Contributor

@dkhaldi dkhaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MrSidims
Copy link
Contributor Author

@intel/llvm-gatekeepers the CI is now passing, may I ask you to merge the PR?

@MrSidims MrSidims requested a review from asudarsa October 16, 2024 17:40
@MrSidims
Copy link
Contributor Author

@intel/llvm-gatekeepers can we merge the PR?

@steffenlarsen
Copy link
Contributor

@MrSidims - Would you mind pushing a merge commit. The testing results are a little old, so it would be good to make sure everything is still in order. Once that's done, this looks ready for a merge.

@steffenlarsen steffenlarsen merged commit b816681 into intel:sycl Oct 18, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants