-
Notifications
You must be signed in to change notification settings - Fork 796
[SYCL][Matrix] Fix bfloat16 component type matrix muladd #15514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Sidorov, Dmitry <dmitry.sidorov@intel.com>
Signed-off-by: Sidorov, Dmitry <dmitry.sidorov@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@intel/llvm-gatekeepers can we merge this please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@intel/llvm-gatekeepers the CI is now passing, may I ask you to merge the PR? |
|
@intel/llvm-gatekeepers can we merge the PR? |
|
@MrSidims - Would you mind pushing a merge commit. The testing results are a little old, so it would be good to make sure everything is still in order. Once that's done, this looks ready for a merge. |
Also outline MatrixOperands calculation into a separate function.