[SYCL][Joint Matrix] Add support for Offset joint_matrix_load and joi #15526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt_matrix_store overloads
dkhaldi
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dkhaldi
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
dkhaldi
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dkhaldi
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
dkhaldi
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dkhaldi
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
| __spv::MatrixLayout L = __spv::MatrixLayout::RowMajor, | ||
| __spv::Scope::Flag S = __spv::Scope::Flag::Subgroup> | ||
| extern __DPCPP_SYCL_EXTERNAL | ||
| __spv::__spirv_JointMatrixINTEL<Tp, R, C, L, S, U> * |
There was a problem hiding this comment.
Hello Dounia! I found this line needs to be updated to __spv::__spirv_CooperativeMatrixKHR<Tp, S, R, C, U> * because a commit merged two weeks ago switched operations to use SPV_KHR_cooperative_matrix (#16045)
| __spv::Scope::Flag S = __spv::Scope::Flag::Subgroup> | ||
| extern __DPCPP_SYCL_EXTERNAL void __spirv_CooperativeMatrixStoreOffsetINTEL( | ||
| T *Ptr, int32_t RowIndex, int32_t ColIndex, | ||
| __spv::__spirv_JointMatrixINTEL<Tp, R, C, L, S, U> *Object, |
There was a problem hiding this comment.
This line would also need to be updated to __spv::__spirv_CooperativeMatrixKHR<Tp, S, R, C, U> *Object for the same reason above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec added in #15499