[Driver][SYCL] Match up -device_options with -device for AOT GPU #15678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The driver will add additional -ftarget-register-alloc-mode values to the spir64_gen AOT call to ocloc. These additional options are applied when a user specifies any of the accepted PVC values that can be handled by ocloc. These values can be 'pvc' or associated hex or version values. Match up the -device_options arg value with the -device arg that is passed on the command line. ocloc expects these to match in order to properly associate the option given after -device_options.
mdtoguchi
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mdtoguchi
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
hchilama
approved these changes
Oct 14, 2024
mdtoguchi
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mdtoguchi
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/llvm-gatekeepers , please take a look, this should be ready or merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The driver will add additional -ftarget-register-alloc-mode values to the spir64_gen AOT call to ocloc. These additional options are applied when a user specifies any of the accepted PVC values that can be handled by ocloc. These values can be 'pvc' or associated hex or version values.
Match up the -device_options arg value with the -device arg that is passed on the command line. ocloc expects these to match in order to properly associate the option given after -device_options.