Skip to content

[SYCL][COMPAT] Add one helper function get_local_mem_size() to get local memory size #15695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 22, 2024
Merged

[SYCL][COMPAT] Add one helper function get_local_mem_size() to get local memory size #15695

merged 2 commits into from
Oct 22, 2024

Conversation

@tomflinda
Copy link
Contributor

@tomflinda tomflinda commented Oct 15, 2024

Signed-off-by: chenwei.sun chenwei.sun@intel.com

@tomflinda tomflinda requested a review from a team as a code owner October 15, 2024 02:50
@tomflinda tomflinda mentioned this pull request Oct 15, 2024
Merged
Alcpz
Alcpz suggested changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@Alcpz Alcpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the signature to the documentation?

@tomflinda
Copy link
Contributor Author

tomflinda commented Oct 15, 2024 •
edited
Loading

Can you add the signature to the documentation?

Done in the latest commit.

@tomflinda
[SYCL][COMPAT] Add one helper function get_local_mem_size() to get lo…
917d9c9 
…cal memory size

Signed-off-by: chenwei.sun <chenwei.sun@intel.com>
Alcpz
Alcpz approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@Alcpz Alcpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes

@tomflinda
Address review comment
21b7562 
Signed-off-by: chenwei.sun <chenwei.sun@intel.com>
@tomflinda
Copy link
Contributor Author

tomflinda commented Oct 22, 2024

@intel/llvm-gatekeepers This PR is ready for merging. Thanks!

@steffenlarsen steffenlarsen merged commit df9a1a6 into intel:sycl Oct 22, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@Alcpz Alcpz Alcpz approved these changes

@zhimingwang36 zhimingwang36 zhimingwang36 approved these changes

@zhiweij1 zhiweij1 zhiweij1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tomflinda @Alcpz @zhimingwang36 @zhiweij1 @steffenlarsen