Skip to content

Conversation

@zhiweij1
Copy link
Contributor

Signed-off-by: Jiang, Zhiwei zhiwei.jiang@intel.com

Signed-off-by: Jiang, Zhiwei <zhiwei.jiang@intel.com>
@zhiweij1 zhiweij1 requested a review from a team as a code owner October 16, 2024 07:54
Signed-off-by: Jiang, Zhiwei <zhiwei.jiang@intel.com>
Copy link

@ziranzha ziranzha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@tomflinda tomflinda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Jiang, Zhiwei <zhiwei.jiang@intel.com>
@zhiweij1
Copy link
Contributor Author

Hi @Alcpz, I moved the definition of has_capability_or_fail() to before the device_ext class (b5a2593) to fix the compile fail in CI. Now CI has passed. Can this PR be merged?

@Alcpz
Copy link
Contributor

Alcpz commented Oct 17, 2024

@zhiweij1 Yes. I am fine with that.
We don´t have rights to merge PRs into DPC++, in order to merge stuff, please ping the intel/llvm-gatekeepers group. As long as you have the approvals and CI passes, they will merge with no issues.

@Alcpz
Copy link
Contributor

Alcpz commented Oct 17, 2024

@intel/llvm-gatekeepers This PR is ready for merging. Thanks!

@martygrant martygrant merged commit ab3af3c into intel:sycl Oct 17, 2024
12 checks passed
@zhiweij1 zhiweij1 deleted the has_capability_or_fail branch October 17, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants