Skip to content

[SYCL][COMPAT] Add a free function version of has_capability_or_fail #15717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 17, 2024
Merged

[SYCL][COMPAT] Add a free function version of has_capability_or_fail #15717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
48ffa5c
[SYCL][COMPAT] Add a free function version of has_capability_or_fail
zhiweij1 Oct 16, 2024
2e24de8
Update
zhiweij1 Oct 16, 2024
b5a2593
Move the free function before member function
zhiweij1 Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions sycl/doc/syclcompat/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1048,6 +1048,10 @@ static inline unsigned int get_device_id(const sycl::device &dev);
// Util function to get the number of available devices
static inline unsigned int device_count();

// Util function to check whether a device supports some kinds of sycl::aspect.
static inline void
has_capability_or_fail(const sycl::device &dev,
const std::initializer_list<sycl::aspect> &props);
} // syclcompat
```

Expand Down
87 changes: 46 additions & 41 deletions sycl/include/syclcompat/device.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,6 +334,51 @@ static int get_minor_version(const sycl::device &dev) {
return minor;
}

static inline void
has_capability_or_fail(const sycl::device &dev,
const std::initializer_list<sycl::aspect> &props) {
for (const auto &it : props) {
if (dev.has(it))
continue;
switch (it) {
case sycl::aspect::fp64:
throw sycl::exception(sycl::make_error_code(sycl::errc::runtime),
"[SYCLcompat] 'double' is not supported in '" +
dev.get_info<sycl::info::device::name>() +
"' device");
break;
case sycl::aspect::fp16:
throw sycl::exception(sycl::make_error_code(sycl::errc::runtime),
"[SYCLcompat] 'half' is not supported in '" +
dev.get_info<sycl::info::device::name>() +
"' device");
break;
default:
#define __SYCL_ASPECT(ASPECT, ID) \
case sycl::aspect::ASPECT: \
return #ASPECT;
#define __SYCL_ASPECT_DEPRECATED(ASPECT, ID, MESSAGE) __SYCL_ASPECT(ASPECT, ID)
#define __SYCL_ASPECT_DEPRECATED_ALIAS(ASPECT, ID, MESSAGE)
auto getAspectNameStr = [](sycl::aspect AspectNum) -> std::string {
switch (AspectNum) {
#include <sycl/info/aspects.def>
#include <sycl/info/aspects_deprecated.def>
default:
return "unknown aspect";
}
};
#undef __SYCL_ASPECT_DEPRECATED_ALIAS
#undef __SYCL_ASPECT_DEPRECATED
#undef __SYCL_ASPECT
throw sycl::exception(
sycl::make_error_code(sycl::errc::runtime),
"[SYCLcompat] '" + getAspectNameStr(it) + "' is not supported in '" +
dev.get_info<sycl::info::device::name>() + "' device");
}
break;
}
}

/// device extension
class device_ext : public sycl::device {
public:
Expand Down Expand Up @@ -613,47 +658,7 @@ Use 64 bits as memory_bus_width default value."
/// sycl::aspect.
void has_capability_or_fail(
const std::initializer_list<sycl::aspect> &props) const {
for (const auto &it : props) {
if (has(it))
continue;
switch (it) {
case sycl::aspect::fp64:
throw sycl::exception(sycl::make_error_code(sycl::errc::runtime),
"[SYCLcompat] 'double' is not supported in '" +
get_info<sycl::info::device::name>() +
"' device");
break;
case sycl::aspect::fp16:
throw sycl::exception(sycl::make_error_code(sycl::errc::runtime),
"[SYCLcompat] 'half' is not supported in '" +
get_info<sycl::info::device::name>() +
"' device");
break;
default:
#define __SYCL_ASPECT(ASPECT, ID) \
case sycl::aspect::ASPECT: \
return #ASPECT;
#define __SYCL_ASPECT_DEPRECATED(ASPECT, ID, MESSAGE) __SYCL_ASPECT(ASPECT, ID)
#define __SYCL_ASPECT_DEPRECATED_ALIAS(ASPECT, ID, MESSAGE)
auto getAspectNameStr = [](sycl::aspect AspectNum) -> std::string {
switch (AspectNum) {
#include <sycl/info/aspects.def>
#include <sycl/info/aspects_deprecated.def>
default:
return "unknown aspect";
}
};
#undef __SYCL_ASPECT_DEPRECATED_ALIAS
#undef __SYCL_ASPECT_DEPRECATED
#undef __SYCL_ASPECT
throw sycl::exception(sycl::make_error_code(sycl::errc::runtime),
"[SYCLcompat] '" + getAspectNameStr(it) +
"' is not supported in '" +
get_info<sycl::info::device::name>() +
"' device");
}
break;
}
::syclcompat::has_capability_or_fail(*this, props);
}

private:
Expand Down
Loading