[UR] Test if new UMF version works properly #15803
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR includes:
* Changes in the program manager methods to be able to properly
create/build UR program for multiple devices. So far, we were mostly
using only the first device in the vector to create/build UR program
which made UR program unusable on other devices.
* UR tag update brings the version of urProgramCreateWithBinary which allows
to create UR program from multiple device binaries.
* Our program cache key allowed only a single device. I have changed it
to contain a set of devices. If UR program is created and built for a
set of devices then the same UR program is usable whenver we have any
subset of this set. That's why if we have a program built for a set of
devices then add all subsets to the cache. Before we were adding a
record to the cache for each device from the set which is incorrect.
For example, if someone requests a UR program for {dev2, dev3} from
the cache then it is expected that this UR progam must be usable to
submit a kernel to dev3. But we could get a program for
{dev1, dev2} from the cache which is unusable on dev3.
lukaszstolarczuk
changed the title
lukaszstolarczuk
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
lukaszstolarczuk
force-pushed
the
verify-new-umf-version
branch
from
98413ed to
d53275d
Compare
lukaszstolarczuk
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
lukaszstolarczuk
force-pushed
the
verify-new-umf-version
branch
from
d53275d to
d1ee9c5
Compare
lukaszstolarczuk
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
|
Included that changes here... |
It's not used right now. --------- Signed-off-by: Sidorov, Dmitry <dmitry.sidorov@intel.com>
test-e2e/DeviceLib/exp/exp-std-complex-double-edge-cases.hpp Removed redundant info, fixed the device code input data, turned off one case for win
lukaszstolarczuk
force-pushed
the
verify-new-umf-version
branch
from
d1ee9c5 to
4f04602
Compare
lukaszstolarczuk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
lukaszstolarczuk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing... oneapi-src/unified-runtime#2200