[SYCL][Graph] Add unit test/mocking for command handle behaviour #15806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Bensuo
commented
Oct 22, 2024
Bensuo
commented
- Add a unit test and mocking functions that check the command handle behaviour changes from [SYCL][Graph] Only get command handle for updatable command-buffers #15522
- Add a unit test and mocking functions that check the command handle behaviour changes from intel#15522
EwanC
approved these changes
Oct 22, 2024
Co-authored-by: Ewan Crawford <ewan@codeplay.com>
|
@steffenlarsen could you review this PR, since you asked for it in #15522 (review) 😉 |
|
@intel/llvm-gatekeepers This is good to merge, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.