[Driver][SYCL] Fix parsing of device values in backend target opts #15876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use of -Xsycl-target-backend=target "opts" was not properly being captured when attempting to find device values to set default values to be used during AOT compilations for GEN.
mdtoguchi
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
clang/lib/Driver/ToolChains/SYCL.cpp
Outdated
| ArgStringList TargArgs; | ||
| Args.AddAllArgValues(TargArgs, options::OPT_Xs, options::OPT_Xs_separate); | ||
| Args.AddAllArgValues(TargArgs, options::OPT_Xsycl_backend); | ||
| // For -Xsycl-target-backend=<triple> we need to scrutinize the triple |
Contributor
There was a problem hiding this comment.
It is not clear to me what this comment means?
Can you help add some more description?
Contributor
Author
There was a problem hiding this comment.
sure - I'll update the comment
mdtoguchi
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mdtoguchi
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
srividya-sundaram
approved these changes
Oct 25, 2024
Contributor
Author
|
@intel/llvm-gatekeepers , please take a look, this should be ready for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of -Xsycl-target-backend=target "opts" was not properly being captured when attempting to find device values to set default values to be used during AOT compilations for GEN.