[SYCL] [E2E] fix reenabled tests #15975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
| @@ -0,0 +1,85 @@ | |||
| // RUN: %if any-device-is-level_zero %{ %{build} -isystem %sycl_include -DBUILD_FOR_L0 -o %t-l0.out %} | |||
Contributor
There was a problem hiding this comment.
Is BUILD_FOR_L0 still used? I think it can be dropped, no?
Contributor
Author
There was a problem hiding this comment.
No, dropped. Thanks.
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
| @@ -0,0 +1,85 @@ | |||
| // RUN: %if any-device-is-level_zero %{ %{build} -isystem %sycl_include -o %t-l0.out %} | |||
Contributor
There was a problem hiding this comment.
Tests which do not execute anything, but only check compilation, should be placed under sycl/test and they should use -fsyntax-only flag as well.
I'm fine with old tests still staying incorrect and be fixed in separate PR, but new tests should be written in a right way.
An alternative is to actually run an executable you build here, because you seem to have a full test. In that case you don't need any %if. Just say REQUIRES: level_zero.
Also, I don't think that you need -isystem %sycl_include at all. %{build} automatically passes -fsycl and the latter sets up all necessary include paths automatically.
Contributor
Author
There was a problem hiding this comment.
It was removed because sycl/test exist: sycl/test/basic_tests/interop-level-zero-2020.cpp and sycl/test/basic_tests/interop-backend-traits-level-zero.cpp
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
Author
|
@AlexeySachkov @cperkinsintel @aelovikov-intel Please, review changes |
AlexeySachkov
approved these changes
Nov 28, 2024
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
Author
|
@aelovikov-intel @cperkinsintel please review it |
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dklochkov-emb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
Author
|
@aelovikov-intel @cperkinsintel please review it |
aelovikov-intel
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.