Skip to content

[DeviceASAN] Enable e2e test "private_nullptr.cpp" #15995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 14, 2024
Merged

[DeviceASAN] Enable e2e test "private_nullptr.cpp" #15995

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3e5f870
enable private_nullptr
AllanZyne Nov 6, 2024
3c4653a
update tracker
AllanZyne Nov 14, 2024
b5103c3
Merge branch 'sycl' into review/yang/enable_nullpointer_private
AllanZyne Nov 14, 2024
f17bbfb
fix tracker
AllanZyne Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions sycl/test-e2e/AddressSanitizer/nullpointer/private_nullptr.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@
// RUN: %{build} %device_asan_flags -O2 -g -o %t3.out
// RUN: %{run} not %t3.out 2>&1 | FileCheck %s

// FIXME: There's an issue in gfx driver, so this test pending here.
// XFAIL: *

#include <sycl/detail/core.hpp>
#include <sycl/ext/oneapi/experimental/address_cast.hpp>

Expand All @@ -22,15 +19,14 @@ int main() {
sycl::nd_range<1>(N, 1), [=](sycl::nd_item<1> item) {
auto private_array =
sycl::ext::oneapi::experimental::static_address_cast<
sycl::access::address_space::private_space,
sycl::access::decorated::no>(array);
sycl::access::address_space::private_space>(array);
private_array[0] = 0;
});
Q.wait();
});
// CHECK: ERROR: DeviceSanitizer: null-pointer-access on Unknown Memory
// CHECK: WRITE of size 4 at kernel {{<.*MyKernel>}} LID(0, 0, 0) GID({{.*}}, 0, 0)
// CHECK: {{.*private_nullptr.cpp}}:[[@LINE-5]]
// CHECK: {{.*private_nullptr.cpp}}:[[@LINE-6]]

return 0;
}
5 changes: 2 additions & 3 deletions sycl/test/e2e_test_requirements/no-xfail-without-tracker.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,13 +51,12 @@
// tests to match the required format and in that case you should just update
// (i.e. reduce) the number and the list below.
//
// NUMBER-OF-XFAIL-WITHOUT-TRACKER: 142
// NUMBER-OF-XFAIL-WITHOUT-TRACKER: 141
//
// List of improperly XFAIL-ed tests.
// Remove the CHECK once the test has been properly XFAIL-ed.
//
// CHECK: AddressSanitizer/nullpointer/private_nullptr.cpp
// CHECK-NEXT: Basic/aspects.cpp
// CHECK: Basic/aspects.cpp
// CHECK-NEXT: Basic/buffer/reinterpret.cpp
// CHECK-NEXT: Basic/device_event.cpp
// CHECK-NEXT: Basic/diagnostics/handler.cpp
Expand Down
Loading