[SYCL][Bindless][E2E] fix double free in vulkan interop unsampled test #16027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cppchedy
commented
Nov 8, 2024
cppchedy
commented
- fix double free in vulkan interop unsampled test
cppchedy
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
cppchedy
force-pushed
the
chedy/fix-mipmap-leak
branch
from
7b72609 to
7ac737a
Compare
cppchedy
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
DBDuncan
reviewed
Nov 13, 2024
|
|
||
| set(UNIFIED_RUNTIME_REPO "https://github.com/oneapi-src/unified-runtime.git") | ||
| include(${CMAKE_CURRENT_SOURCE_DIR}/cmake/modules/UnifiedRuntimeTag.cmake) | ||
| set(UNIFIED_RUNTIME_TAG 698cd9974c18874bf6a7e9ec78507c30b9deeca7) |
There was a problem hiding this comment.
I believe now you need to instead edit UnifiedRuntimeTag.cmake with the new commit and leave this line unedited.
There was a problem hiding this comment.
ah. thank you. I missed this change. fixed now
cppchedy
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
cppchedy
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
przemektmalon
approved these changes
Nov 19, 2024
DBDuncan
approved these changes
Nov 21, 2024
cppchedy
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
cppchedy
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cppchedy
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
# Conflicts: # sycl/cmake/modules/UnifiedRuntimeTag.cmake
# Conflicts: # sycl/cmake/modules/UnifiedRuntimeTag.cmake
|
Friendly ping @intel/unified-runtime-reviewers . Tests passed and the UR PR is ready to merge. |
We'll try and fit this in as soon we can once we've merged all the features for the next release. |
martygrant
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.