[SYCL] Move SYCLLowerWGLocalMemoryPass to PipelineStart #16183
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pass transforms __sycl_allocateLocalMemory call to access of global variable @WGLocalMem. Move the transform to beginning of the pipeline since the access could enable more optimization than the function call. In addition, intel gpu compiler has a pass to transform global variable in addrspace(3) to alloca that runs after pipeline basic simplification. Therefore, we shall run SYCLLowerWGLocalMemoryPass ealier.
wenju-he
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
bader
reviewed
Nov 26, 2024
wenju-he
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Contributor
Author
|
sorry, SYCLLowerWGLocalMemoryPass requires AlwaysInlinerPass to run first as the test failure in CI shows. AlwaysInlinerPass runs later than PipelineStart. So SYCLLowerWGLocalMemoryPass can't run in PipelineStart. Close this pr. |
wenju-he
deleted the
move-SYCLLowerWGLocalMemoryPass-PipelineStartEPCallback
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pass transforms __sycl_allocateLocalMemory call to access of global variable @WGLocalMem. Move the transform to beginning of the pipeline since the access could enable more optimization than the function call.
In addition, intel gpu compiler has a pass to transform global variable in addrspace(3) to alloca that runs after pipeline basic simplification. Therefore, we shall run SYCLLowerWGLocalMemoryPass ealier.