[SYCL][RTC] Preliminary support for ESIMD kernels #16222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julian Oppermann <julian.oppermann@codeplay.com>
Signed-off-by: Julian Oppermann <julian.oppermann@codeplay.com>
sommerlukas
reviewed
Dec 2, 2024
Contributor
sommerlukas
left a comment
sommerlukas
left a comment
There was a problem hiding this comment.
Just a few nits & questions.
| MDesc = std::move(ESIMDSplits.front()); | ||
|
|
||
| if (MDesc.isESIMD()) { | ||
| // TODO: We're assuming ESIMD lowering is not deactivated (why would it?). |
Contributor
There was a problem hiding this comment.
How would it be deactivated? Through a user option?
Contributor
Author
There was a problem hiding this comment.
The driver would deactivate it (i.e. not pass -lower-esimd to sycl-post-link) in the IR-only output mode, which is only relevant for spec constant processing IIUC. Otherwise it doesn't seem to be influenced by a user-option. I updated the comment to reflect this.
| FunctionPassManager MainFPM; | ||
| MainFPM.addPass(ESIMDLowerLoadStorePass{}); | ||
|
|
||
| if (!PerformOpts) { |
Contributor
There was a problem hiding this comment.
Is the negation correct here?
| namespace jit_compiler { | ||
|
|
||
| // Runs a pass pipeline to lower ESIMD constructs on the given split model, | ||
| // which may only contain ESIMD entrypoints. This is a copy of the similar |
Signed-off-by: Julian Oppermann <julian.oppermann@codeplay.com>
cperkinsintel
approved these changes
Dec 2, 2024
sommerlukas
approved these changes
Dec 3, 2024
Signed-off-by: Julian Oppermann <julian.oppermann@codeplay.com>
Contributor
Author
|
@intel/llvm-gatekeepers Please merge, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for compiling source strings that contain ESIMD kernels only, hence require no device splitting. I'm using a simplified version of the driver logic in
sycl-post-link. The pass pipeline construction helperlowerEsimdConstructsis also copied fromsycl-post-link.