Skip to content

Conversation

@aelovikov-intel
Copy link
Contributor

Reverts #16179

template <source_language Lang>
__SYCL_EXPORT std::vector<byte> online_compiler<Lang>::compile_impl(
    detail::string_view Src, detail::string_view DeviceStepping,
    const std::vector<detail::string_view> &Options) {

accesses this->CompileToSPIRVHandle which is laid out after std::string data member:

  /// Target device stepping (implementation defined)
  std::string DeviceStepping;

  /// Handles to helper functions used by the implementation.
  void *CompileToSPIRVHandle = nullptr;

resulting in ABI incompatibility.

@aelovikov-intel aelovikov-intel merged commit 3f1aa18 into sycl Dec 4, 2024
15 checks passed
@bader bader deleted the revert-16179-cxx11abi-online-compiler branch December 24, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants